Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Improve overflowing of SubdomainNavBar on mobile #405

Closed
simurai opened this issue Aug 24, 2023 · 0 comments · Fixed by #451
Closed

[Accessibility] Improve overflowing of SubdomainNavBar on mobile #405

simurai opened this issue Aug 24, 2023 · 0 comments · Fixed by #451
Assignees
Labels

Comments

@simurai
Copy link
Contributor

simurai commented Aug 24, 2023

This came up in https://github.com/github/accessibility-audits/issues/5254. The SubdomainNavBar on mobile could run into overflow issues (overlapping) when there is not enough height and lots of items. Or in this case when zoomed in to 200%:

An option might be to add some overflow scrolling when the height runs out. But it might be tricky to fix since the extra buttons (at the bottom) are positioned absolutely? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Primer Brand roadmap
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants