Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Allow <Label> in River + Bentos #508

Closed
simurai opened this issue Dec 4, 2023 · 1 comment · Fixed by #517
Closed

[Feature request] Allow <Label> in River + Bentos #508

simurai opened this issue Dec 4, 2023 · 1 comment · Fixed by #517
Assignees
Labels

Comments

@simurai
Copy link
Contributor

simurai commented Dec 4, 2023

Problem

The Copilot page has features that are not available for everyone. So we used a <Label> to mark something as only available for "Enterprise".

River Bento
Image Image

Unfortunately, <Label> is not supported as a child of River and Bento.

Possible solution

Allow <Label> as a child of River and Bento. Ideally, positioned at the top.

Urgency

This is not too urgent. The current workaround is not very pretty, but works for now:

  1. Add the <Label> inside <Heading>. 😈
  2. Then use some custom styles to reset the inherited <Heading> styles.
<River.Content>
  <Heading as="h3">
    <Label className="Label--inRiver">Copilot Enterprise</Label>
    Docs that feel tailored for you.
  </Heading>
.Label--inRiver {
  display: block;
  width: fit-content;
  margin-bottom: var(--brand-River-heading-margin);
  font-size: var(--brand-text-size-300);
  letter-spacing: normal;
}
@nsolerieu
Copy link
Contributor

Interface guidelines notes from Site Design:

  • Don't use long unique label. in most case Labels are intended to convey the status of something, in most cases new but also limited, beta...
  • Don't feature on a label on every single river of a page. Labels are meant to be a callout.

Once this is implemented let me know and I'll get a PR going to add these to the river component doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants