Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] FAQ.Item is not getting closed using 'ESC' key #519

Closed
simurai opened this issue Dec 22, 2023 · 0 comments · Fixed by #523
Closed

[Accessibility] FAQ.Item is not getting closed using 'ESC' key #519

simurai opened this issue Dec 22, 2023 · 0 comments · Fixed by #523
Assignees
@rezrah

Comments

@simurai
Copy link
Contributor

simurai commented Dec 22, 2023 •
edited

This came up in https://github.com/github/accessibility-audits/issues/7115 and affects the FAQ component.

As I understood it, when the focus is either:

  • on an FAQ.Item
  • or on a link inside an FAQ.Item

pressing the esc key should collapse the FAQ.Item again. And I assume keep/move the focus on the just collapsed FAQ.Item.

Focus on item

Focus on link inside item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezrah rezrah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add escape key handlers to open accordions and its inner content primer/brand
2 participants
@simurai @rezrah