Text input tweaks ✨ #652
Merged
Text input tweaks ✨ #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 16, 2019 14:39
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/nqmr9cqz6 |
BinaryMuse
approved these changes
Dec 19, 2019
| const inputClasses = classnames(icon ? 'input-icon' : 'input-no-icon') | ||
| const hasIcon = !!icon | ||
| const wrapperProps = pick(rest) | ||
| const inputProps = omit(rest) |
There was a problem hiding this comment.
it's extremely useful for wrapper components like this!!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a few things around the
TextInputandFilteredSearchcomponents.FilteredSearchdocs to make sure users are aware that the component must be used with aTextInputandDropdownin order for it to work correctlyTextInputinput-icon&input-no-iconclassesinputtype="search"from docs - we usetype="text"on GitHub.comWrapperelement, usesomitandpickfrom@styled-system/propsto pass the appropriate props to theWrapperandInput. This fixes a bunch of issues with havingCOMMONon the input (margin getting applied in the wrong place, etc).