Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Update link to theme file ⚠️ #806

Merged
merged 1 commit into from May 11, 2020
Merged

⚠️ Update link to theme file ⚠️ #806

merged 1 commit into from May 11, 2020

Conversation

albingroen
Copy link
Contributor

@albingroen albingroen commented May 8, 2020

Fixes a issue where the link to the theme file from the documentation page does not link to the actual theme file on github. This fixes this.

Closes #805

Screenshots

Before

CleanShot 2020-05-08 at 22 44 02

After

CleanShot 2020-05-08 at 22 44 59

Merge checklist

  • Added or updated TypeScript definitions (index.d.ts) if necessary
  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@vercel
Copy link

vercel bot commented May 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/2h7ps5fev
✅ Preview: https://primer-components-git-fork-albingroen-patch-theme-link.primer.now.sh

@vercel vercel bot temporarily deployed to Preview May 8, 2020 20:46 Inactive
@albingroen albingroen changed the title Update link to theme file ⚠️ Update link to theme file ⚠️ May 8, 2020
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you! 🙌

@emplums emplums merged commit 314f896 into primer:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞 Bug] Link to theme-file needs to be patched
2 participants