Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialogs to Messaging section #105

Open
emplums opened this issue May 20, 2020 · 0 comments
Open

Add dialogs to Messaging section #105

emplums opened this issue May 20, 2020 · 0 comments
Assignees

Comments

@emplums
Copy link

emplums commented May 20, 2020

I noticed that the Messaging section doesn't include anything about details-dialog elements that are frequently used to confirm actions or provide more information. Though we don't maintain details-dialog I still think it would make sense to provide usage guidelines for them as they are frequently used bits of our UI.

Example of a details-dialog being used to confirm actions:
image

It also seems anti-pattern to put a question in the header/title of the dialog - maybe we could provide some usage guidelines for that as well.

@emplums emplums changed the title Add Dialogs to Messaging section Add dialogs to Messaging section May 20, 2020
@yaili yaili self-assigned this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants