Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile navigation in macOS Safari #56

Closed
colebemis opened this issue Aug 19, 2019 · 1 comment
Closed

Fix mobile navigation in macOS Safari #56

colebemis opened this issue Aug 19, 2019 · 1 comment
Assignees

Comments

@colebemis
Copy link
Contributor

colebemis commented Aug 19, 2019

Problem

In macOS Safari, clicking links below the fold in the responsive navigation drawer causes focus to jump to the first link instead of going the destination of the link.

Here's a codesandbox that reproduces the issue: https://codesandbox.io/s/responsive-navigation-safari-bug-6hvj4

Notes

  • Removing the FocusLock component from the Drawer component fixes this issue.

  • Removing tabIndex="-1" from the wrapper div created by @reach/router also fixes this issue:

    image

@colebemis colebemis added the bug label Aug 20, 2019
@colebemis colebemis added this to To do in Doctocat tracking Aug 26, 2019
@colebemis colebemis moved this from Backlog to To do in Doctocat tracking Aug 26, 2019
@colebemis colebemis self-assigned this Aug 26, 2019
@colebemis colebemis moved this from To do to In progress in Doctocat tracking Aug 26, 2019
@colebemis colebemis moved this from In progress to To do in Doctocat tracking Aug 26, 2019
@colebemis colebemis moved this from To do to In progress in Doctocat tracking Aug 27, 2019
@colebemis colebemis moved this from In progress to In review in Doctocat tracking Aug 29, 2019
@colebemis colebemis moved this from In review to Done in Doctocat tracking Aug 29, 2019
@colebemis
Copy link
Contributor Author

Closed by #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant