Make sure recommended.js is up-to-date and dependecies are up-to-date

[khiga8]

The component to tag mappings in recommended.js have not been updated for a while, and is overdue for a review.

In addition, this library is behind on jsx-a11y and eslint-plugin-github dependency updates.

We have a mapping that is used in eslint-plugin-jsx-a11y and a mapping that is used in eslint-plugin-github. The latter should be deprecated since it was an experimental feature that is deprecated in the latest eslint-plugin-github.

• Are there any component to tag mappings that should be newly added? (Notably, jsx-a11y supports 1:1 component to tag mapping). However, we should be wary of adding some mappings that could raise a false positive. For example, if we map Avatar to img, but it already sets alt internally default, the ESLint rule may incorrectly flag that there's a missing alt.
• Are there any component to tag mappings that should be removed?

Acceptance criteria

• Bump eslint-plugin-github and eslint-plugin-jsx-a11y dependency to the latest
• Ensure that the configs are up-to-date.

[TylerJDev]

Hey @khiga8, this sounds good!

Just to clarify, is the idea to remove the mappings under "github" in the recommended.js file?

As far as the mapping in jsx-a11y, we definitely could add additional mappings. Nothing comes to mind right now, but I can review our current list of components to see if any of them would benefit from being mapped.

[khiga8]

Hey @TylerJDev! We're going to release a new version of eslint-plugin-github hopefully tomorrow, once these two PRs are merged in:

• Bump aria-query and update to fix tests github/eslint-plugin-github#448
• Rename role-supports-aria-props to a11y- github/eslint-plugin-github#454

So I would encourage bumping to that version once it's out!

Here's what changed:

• The existing mapping currently under github can be removed. that format has been deprecated thanks to Kendall's work in Add polymorphic component check in getElementType github/eslint-plugin-github#449.
• If we want to define component mapping for accessibility rules now in eslint-plugin-github too, we now support the same format as jsx-a11y. They are documented in https://github.com/github/eslint-plugin-github#component-mapping-experimental.

[TylerJDev]

Sounds good! I'll create a draft PR that should include some of the changes suggested!

[TylerJDev]

Closing per #67.

[khiga8]

@TylerJDev should we keep this open until the false positives flags are fixed? 🤔

[TylerJDev]

@khiga8, I was planning on creating a separate issue to track these. But I don't have a preference either way.

[khiga8]

Ooh that sounds good! Just want to make sure your follow-up efforts are tracked! :)