Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octicon request: Archived repo #182

Closed
sophshep opened this issue Oct 26, 2017 · 8 comments · Fixed by #220
Closed

Octicon request: Archived repo #182

sophshep opened this issue Oct 26, 2017 · 8 comments · Fixed by #220
Assignees

Comments

@sophshep
Copy link

We need an icon to represent an archived repo. No major rush on it, but if/when we start adding icons again or redesign the system, I wanted to record this.

UI examples and conversation happening here: https://github.com/github/github/pull/80421)

@broccolini broccolini self-assigned this Oct 27, 2017
@broccolini
Copy link
Member

I'll grab this one, it's a good excuse to go through the entire flow (and document it) with the new monorepo.

@colinkeany
Copy link

Hey, hope it's alright to jump in on this issue, but I spoke with @jonrohan and @broccolini yesterday about also needing an "archive" icon, and we decided I could be the guinea pig for the new octicon contributor flow via Figma. So here we go!

I've added 2 versions of an archive icon in this file. One is based on some of the feedback from this issue linked above, and the other is an alternative I thought could be interesting, and holds up a little better at a smaller scale.

Link to my draft of the octicons file: https://www.figma.com/file/taeondve1a0gWuNuEN4RJ3/Octicons-Colin-Adding-Archive-Icon

Screenshots:

Archive icon 1
screen shot 2018-04-05 at 11 46 40 am

Archive icon 2
screen shot 2018-04-05 at 11 46 44 am

Smaller
screen shot 2018-04-05 at 11 39 41 am

In context (issue timeline)

Icon 1, dark icon on light bg
screen shot 2018-04-05 at 11 36 20 am

Icon 1, light icon on dark bg
screen shot 2018-04-05 at 11 35 30 am

Icon 2, dark icon on light bg
screen shot 2018-04-05 at 11 39 00 am

Icon 2, light icon on dark bg
screen shot 2018-04-05 at 11 38 29 am

@jonrohan
Copy link
Member

jonrohan commented Apr 5, 2018

One thing I'll comment on is I feel even though the iconography of the filled in one with the arrow is less clear, I do like that it's filled in because of the contrast from the repo icon. Which would make it more useful at a glance.

frame

@colinkeany
Copy link

Yeah I had similar feelings about how the outlined box icon held up in comparison to the arrow icon.

I'm leaning a little more in the direction of the box icon only for the sake of clarity. I do think the arrow icon has some traction as an "archive" icon, but I don't have examples right now to back that up.

@colinkeany
Copy link

Bump!

We're making good progress on the project card archival feature and I would love to be able to get an icon sorted out for this so we can start including it in the UI. What can I do to help move this along?

@colinkeany
Copy link

Some updates based on the discussion at design review:

Filled in box icon

screen shot 2018-04-21 at 10 07 11 am
screen shot 2018-04-21 at 10 07 21 am
screen shot 2018-04-21 at 10 04 02 am

@broccolini
Copy link
Member

@colinkeany I think the original outline box works best and fits with the other icons. Icon 1 dark on light background seems like a good combo. Would you be happy moving forward with that? If so, we can help you with adding this to Octicons.

@colinkeany
Copy link

@broccolini yup that's good with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants