Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.4.0 version distribution broken #282

Closed
purdrew opened this issue Feb 8, 2019 · 2 comments · Fixed by #284
Closed

8.4.0 version distribution broken #282

purdrew opened this issue Feb 8, 2019 · 2 comments · Fixed by #284

Comments

@purdrew
Copy link

purdrew commented Feb 8, 2019

The package.json for version 8.4.0 lists the following entry points:

  "main": "dist/index.umd.js",
  "module": "dist/index.esm.js",

Neither of those files actually exist in the installed dist directory. The only files in the dist directory are:

icons.d.ts
index.d.ts

Version 8.3.0 includes the proper dist files.

@jonrohan
Copy link
Member

jonrohan commented Feb 8, 2019

Thanks for the report, didn't mean to break anything. lemme check what might have happened

This was referenced Feb 8, 2019
@hiendv
Copy link

hiendv commented Feb 11, 2019

octicons/build/build.css is also missing and I couldn't find any backlog about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants