Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM build of 8.4+ is missing build.css #290

Closed
kpfefferle opened this issue Feb 18, 2019 · 2 comments
Closed

NPM build of 8.4+ is missing build.css #290

kpfefferle opened this issue Feb 18, 2019 · 2 comments
Assignees
@jonrohan
Projects
Octicons release tracking

Comments

@kpfefferle
Copy link

Starting with the 8.4 release, the NPM distribution of Octicons no longer contains the normalizing CSS found in build/build.css. The README distributed through NPM still suggests using this file to normalize the display of the SVG icons, so this seems to be an unintentional breaking change.
@kpfefferle kpfefferle mentioned this issue Feb 18, 2019
Closed
@shawnbot
Copy link
Contributor

Thanks for letting us know, @kpfefferle! We'll track it down as soon as possible.

@jonrohan jonrohan added this to Next Release in Octicons release tracking Feb 19, 2019
@jonrohan jonrohan mentioned this issue Feb 19, 2019
Merged
@jonrohan
Copy link
Member

Fixed in 8.4.2

Octicons release tracking automation moved this from Next Release to 💜 Done Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonrohan jonrohan

Labels
None yet
Projects
No open projects
Octicons release tracking
  
💜 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonrohan @shawnbot @kpfefferle