Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming discrepancy of trash and trashcan icons? #537

Closed
fermion opened this issue Jan 20, 2021 · 2 comments · Fixed by #538
Closed

Naming discrepancy of trash and trashcan icons? #537

fermion opened this issue Jan 20, 2021 · 2 comments · Fixed by #538

Comments

@fermion
Copy link
Contributor

fermion commented Jan 20, 2021

👋🏻 noticed this while using the octicons_helper gem in conjunction with primer on a personal project. It looks like the two trash can icons have different names depending on the target size used, trash for 16px and trashcan for 24px.

I forked the repo and was going to submit a PR to update the file name but I wanted to check and see if the name mismatch was intentional. Thanks in advance ✨
@colebemis
Copy link
Contributor

Nice catch! That was not intentional. We'd love a PR ❤️ Let's call them both trash

@fermion fermion mentioned this issue Jan 20, 2021
Merged
@ashygee
Copy link
Contributor

ashygee commented Feb 4, 2021

@fermion this update has been included in our v12.0.0 release :)

@ashygee ashygee closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renames trashcan-16 icon to trash-16
3 participants
@fermion @colebemis @ashygee