Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 16px circle icon is slightly mis-aligned #583

Closed
simurai opened this issue Apr 5, 2021 · 2 comments · Fixed by #584
Closed

The 16px circle icon is slightly mis-aligned #583

simurai opened this issue Apr 5, 2021 · 2 comments · Fixed by #584
Assignees

Comments

@simurai
Copy link

simurai commented Apr 5, 2021

Reported by @laserlemon in Slack

i just wanted to point out that the (new?) circle octicon doesn’t seem to actually be a perfect circle at the 16px size. see: https://primer.style/octicons/circle-16 vs https://primer.style/octicons/issue-opened-16. the top is flattened. 24px looks

I didn't really see it, but when taking a screenshot and then zooming in with "render pixels" in Sketch, it seems that the circle is slightly off center and maybe needs to be nudged a tiny bit?

Screen Shot 2021-04-05 at 22 55 19

@laserlemon
Copy link

laserlemon commented Apr 5, 2021

It could just be how it’s rendered in primer.style but the flat spots on the top and left were clearer there:

Screen Shot 2021-04-05 at 10 04 35 AM

@laserlemon
Copy link

Strangely, this didn't close when #584 landed. I'd close it myself but I'm not allowed! 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants