Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octicon-logo-github has a bunch of extra whitespace at the bottom #59

Closed
mnquintana opened this issue Jun 21, 2015 · 3 comments
Closed
Milestone

Comments

@mnquintana
Copy link

Compared to other Octicons, .octicon-logo-github has a lot of extra whitespace at the bottom, which ends up meaning that in practice, it needs to be treated specially from other Octicons (ie. the extra bottom margin is removed to make it consistent and align with other Octicons).

Hopefully the screenshot makes the bottom margin difference clear enough:
screenshot 2015-06-20 22 36 18

@tarebyte
Copy link

tarebyte commented Sep 5, 2015

@cameronmcefee any idea why this is?

@cameronmcefee
Copy link

My first guess is that it's because the icons were optimized for use in 16pt lines. Or it could just be an oversight. We'll have a look at it in future versions.

cc @aaronshekey

@jonrohan jonrohan added this to the v4.0.0 milestone Feb 14, 2016
@jonrohan
Copy link
Member

jonrohan commented Jun 6, 2016

fixed in #89

@jonrohan jonrohan closed this as completed Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants