Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package is not built for publish #127

Closed
brianzelip opened this issue Jun 4, 2021 · 3 comments
Closed

npm package is not built for publish #127

brianzelip opened this issue Jun 4, 2021 · 3 comments

Comments

@brianzelip
Copy link

Hi Primer team!

There is no dist/ directory in the latest npm package.

When I install via npm i @primer/primitives@v4.3.9 (v4.3.10, or npm i @primer/primitives, fails to install), only the source code is there, not the built output. See the contents to the left below:

image

Looks like a job for npm run release.

Cheers, love the dark dimmed theme!

@colebemis
Copy link
Contributor

Interesting. Can you try now? It looks like the dist directory is published: https://unpkg.com/browse/@primer/primitives@4.3.10/dist/

@brianzelip
Copy link
Author

Yup, https://unpkg.com/@primer/primitives now resolves, and npm i @primer/primitives creates the expected package contents in node_modules/.

Did something change, or was it something weird on my end?

@simurai
Copy link
Contributor

simurai commented Jun 5, 2021

@brianzelip Yeah, I experienced some weirdness too, see #126 (comment). Not sure, but maybe some npm glitch or it was temporarily down?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants