Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint json5 #389

Closed
lukasoppermann opened this issue Nov 10, 2022 · 1 comment
Closed

Eslint json5 #389

lukasoppermann opened this issue Nov 10, 2022 · 1 comment
Assignees
@rezrah

Comments

@lukasoppermann
Copy link
Contributor

lukasoppermann commented Nov 10, 2022 •
edited
Loading

Support for .json5 formatting

With the current setup .json and .json5 files are not formatted at all.

Reproduction steps

1. Go to any `.json5` file
2. Update it, e.g. with wrong indentation
3. see that nothing happens on save or format

Expected behavior

Saving a `.json5` file or running `format document` on it should format it correctly.
@lukasoppermann lukasoppermann added the bug Something isn't working label Nov 10, 2022
@lukasoppermann lukasoppermann changed the title Eslint formatting for json5 in vscode Eslint updates / improvements Dec 2, 2022
@lukasoppermann lukasoppermann added enhancement and removed bug Something isn't working labels Dec 2, 2022
@lukasoppermann lukasoppermann changed the title Eslint updates / improvements Eslint json5 Dec 2, 2022
@lukasoppermann
Copy link
Contributor Author

I actually created a new ticket for another eslint issue: #433

I am thinking if we should remove json5 and use readme files instead. If we do this we could remove this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezrah rezrah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasoppermann @rezrah