Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnderlineNav follow up items #128

Closed
3 of 4 tasks
emplums opened this issue Jul 13, 2018 · 1 comment
Closed
3 of 4 tasks

UnderlineNav follow up items #128

emplums opened this issue Jul 13, 2018 · 1 comment

Comments

@emplums
Copy link

emplums commented Jul 13, 2018

🐛 Bugs

  • Underline is red-orange when Kit is first loaded, but once you navigate to other tabs, it turns grey.

🚀 Enhancements

  • Spread children's props back onto cloned child
  • Move rendersClass into utility file
  • Consider whether or not it's ok to have a circular dependency between UnderlineNav and UnderlineNavLink
@shawnbot
Copy link
Contributor

All of the enhancements listed above are addressed in #134.

@shawnbot shawnbot moved this from v0.0.11-beta To Do to 🙇‍♀️ WIP in Primer Components release tracking 📋 Jul 16, 2018
@emplums emplums moved this from 🙇‍♀️ WIP to v0.0.11-beta completed in Primer Components release tracking 📋 Jul 19, 2018
@emplums emplums closed this as completed Jul 19, 2018
@emplums emplums moved this from v0.0.11-beta completed to 🚢Published in Primer Components release tracking 📋 Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants