Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Emoji Picker API doc #1711

Closed
wants to merge 1 commit into from
Closed

Adding Emoji Picker API doc #1711

wants to merge 1 commit into from

Conversation

dusave
Copy link
Contributor

@dusave dusave commented Dec 9, 2021

Describe your changes here.

Adds the Emoji Picker API doc

Screenshots

emoji picker

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@dusave dusave requested review from a team and pksjce December 9, 2021 18:58
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2021

⚠️ No Changeset found

Latest commit: d36a117

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 56.98 KB (0%)
dist/browser.umd.js 57.29 KB (0%)

@pksjce
Copy link
Collaborator

pksjce commented Dec 13, 2021

This is so cool.
The custom category is the tabs on the top? And it converts icons to emojis?

@dusave
Copy link
Contributor Author

dusave commented Dec 13, 2021

@pksjce Thanks! ❤️

The custom categories are for any additional categories the user might need in addition to the standard unicode emoji set, such as our GitHub category. Each category contains an icon for the tab bar on top as well as an array of emojis (in the form of React Nodes) which can be images, other components, etc.

@pksjce
Copy link
Collaborator

pksjce commented Dec 13, 2021

Would be good to document what arguments are returned in onSelect? I'm not sure what to expect out of that callback.
Also do you think any of the parts will be optional? Like the searchbar? And do you think we'll need a lite down version of the picker too?

@dusave
Copy link
Contributor Author

dusave commented Dec 15, 2021

Interesting questions 🤔 I could see both. Toggling the search bar would be easy enough, but a compact view would require thought and designs. That said, I agree that a compact view could be valuable for certain use cases.

@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 13, 2022
@github-actions github-actions bot closed this Feb 20, 2022
@github-actions github-actions bot deleted the emoji-picker-api branch February 20, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants