Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide: should we export our styled Octicon component? #223

Closed
shawnbot opened this issue Aug 21, 2018 · 2 comments
Closed

Decide: should we export our styled Octicon component? #223

shawnbot opened this issue Aug 21, 2018 · 2 comments
Assignees
Labels
💓collab a vibrant hub of collaboration type: discussion

Comments

@shawnbot
Copy link
Contributor

We have an internal version of the Octicon component from the octicons-react package with system props. I think it makes sense to export for public consumption, but we have a couple of options for doing so:

  1. Just export Octicon from primer-react as-is;
  2. Call it something more explicit, like PrimerOcticon (which seems redundant to me);
  3. Nix our styled component and update our examples to wrap it in <Text> or <Box> to apply margins, etc.
@shawnbot shawnbot added 💓collab a vibrant hub of collaboration type: discussion labels Aug 21, 2018
@emplums emplums moved this from Backlog to Sprint [10/5] To Do in Primer Components release tracking 📋 Oct 10, 2018
@emplums emplums moved this from Sprint [10/5] To Do to Backlog in Primer Components release tracking 📋 Oct 12, 2018
@emplums emplums moved this from Backlog to Sprint [10/26] To Do in Primer Components release tracking 📋 Oct 23, 2018
@emplums emplums mentioned this issue Oct 23, 2018
19 tasks
@broccolini
Copy link
Member

Let's call it StyledOcticon.

@shawnbot
Copy link
Contributor Author

Decided! 😁

Primer Components release tracking 📋 automation moved this from Sprint [10/26] To Do to Sprint [10/26] Completed Oct 24, 2018
@emplums emplums moved this from Sprint [10/26] Completed to 🚢Published in Primer Components release tracking 📋 Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💓collab a vibrant hub of collaboration type: discussion
Projects
No open projects
Development

No branches or pull requests

2 participants