You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have an internal version of the Octicon component from the octicons-react package with system props. I think it makes sense to export for public consumption, but we have a couple of options for doing so:
Just export Octicon from primer-react as-is;
Call it something more explicit, like PrimerOcticon (which seems redundant to me);
Nix our styled component and update our examples to wrap it in <Text> or <Box> to apply margins, etc.
The text was updated successfully, but these errors were encountered:
We have an internal version of the Octicon component from the
octicons-react
package with system props. I think it makes sense to export for public consumption, but we have a couple of options for doing so:Octicon
fromprimer-react
as-is;PrimerOcticon
(which seems redundant to me);<Text>
or<Box>
to apply margins, etc.The text was updated successfully, but these errors were encountered: