Make an Octicons component

[broccolini]

In use this might look like <Icon alert />.

This article seems to provide a good approach: http://nicolasgallagher.com/making-svg-icon-libraries-for-react-apps/

[jonrohan]

<Icon alert />

I'm not aware this is valid. In the article he suggests <Icon name='camera' /> Could you provide some examples of components that have properties like this so I can understand how they work?

[broccolini]

An example of this approach would be buttons, we have props for small and large so that we can do things like the following:

https://github.com/primer/primer-react/blob/0f251ca2cf121c2c9c8368d64d3bb626fc8425bd/src/Index.js#L65-L67

Anyhow, that was more to say that Octicons should be a component with a way of defining which specific Octicon to use. The approach you've followed from Nicolas Gallagher's article is great.