Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need individual packages or not? #31

Closed
broccolini opened this issue May 22, 2018 · 2 comments
Closed

Do we need individual packages or not? #31

broccolini opened this issue May 22, 2018 · 2 comments

Comments

@broccolini
Copy link
Member

In primer/primer we have a separate package for each component or group of styles. We set it up like this so that people could only pull in the styles they need so as to avoid unnecessary bloat. Do we need to do this with React components? We don't have quite the same concerns with CSS bloat. I do think we will still have some distinction between dotcom and marketing sites, so perhaps there is an "addons" package, but otherwise maybe we don't need to break it up quite as much. Let me know what you think!

cc @primer/ds-core

@shawnbot
Copy link
Contributor

Tree shaking kinda does the thing in JS land, so I’m for this until there’s a clearer need for npm module separation. We can move more quickly and nimbly without the monorepo.

@shawnbot
Copy link
Contributor

I feel like we've agreed not to do this a couple of times. Closing for now because it's not on the roadmap.

Primer Components release tracking 📋 automation moved this from Backlog to 2.0.0-beta Completed Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Primer Components release tracking 📋
  
Complete & Merged Into Release Br...
Development

No branches or pull requests

2 participants