Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility check @emplums #325

Closed
9 of 13 tasks
emplums opened this issue Oct 23, 2018 · 0 comments
Closed
9 of 13 tasks

Accessibility check @emplums #325

emplums opened this issue Oct 23, 2018 · 0 comments
Projects
Primer Components release tracking 📋

Comments

@emplums
Copy link

emplums commented Oct 23, 2018 •
edited

  • aria labels / other a11y attributes should be able to be passed down via props for appropriate components
    • Button
    • TextInput
    • Octicon
    • CircleOcticon
    • CircleBadge
  • add guidelines for using a link vs button in docs
  • double check that jsx-a11y is running on lint
  • run Chrome a11y audit on docs
  • alt tags can be passed down for any img tags, documentation encourages users to do so
  • add blurb to Heading docs about appropriate heading structure & a11y implications
  • make sure API of TextInput makes it easy to apply a label, make sure docs instruct to do so
  • make sure outline: none isn't being used anywhere
@emplums emplums created this issue from a note in Primer Components release tracking 📋 (Sprint [10/26] To Do) Oct 23, 2018
@emplums emplums added the v1 label Oct 23, 2018
@shawnbot shawnbot added the a11y label Oct 23, 2018
@emplums emplums mentioned this issue Oct 23, 2018
Closed
19 tasks
@emplums emplums moved this from Sprint [10/26] To Do to Sprint [10/26] Completed in Primer Components release tracking 📋 Nov 5, 2018
@emplums emplums moved this from Sprint [10/26] Completed to 🚢Published in Primer Components release tracking 📋 Nov 5, 2018
@emplums emplums closed this as completed Nov 5, 2018
Primer Components release tracking 📋 automation moved this from 🚢Published to Sprint [10/26] Completed Nov 5, 2018
@emplums emplums moved this from Sprint [10/26] Completed to 🚢Published in Primer Components release tracking 📋 Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Primer Components release tracking 📋
  
🚢Published
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawnbot @emplums