Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton is using color fg.default instead of fg.muted #4344

Closed
maximedegreve opened this issue Mar 4, 2024 · 2 comments · Fixed by #4364
Closed

IconButton is using color fg.default instead of fg.muted #4344

maximedegreve opened this issue Mar 4, 2024 · 2 comments · Fixed by #4364
Assignees

Comments

@maximedegreve
Copy link
Contributor

maximedegreve commented Mar 4, 2024

Description

Throughout GitHub I suddenly noticed that all our IconButton components use a fg.default instead of fg.muted. This creates inconsistencies with high surfacing areas like the global navigation or UnderlineNav where the icons are always muted. It also doesn't match the previews in our documentation.

For context our icons inside a normal button are also fg.muted.

Storybook example demonstrating the issue

Steps to reproduce

Visit our storybook

Version

Latest

Browser

Safari

@joshblack
Copy link
Member

@maximedegreve just wanted to confirm, are you also seeing this behavior in PVC, as well? Was taking a look over at: https://view-components-storybook.eastus.cloudapp.azure.com/view-components/lookbook/inspect/primer/beta/icon_button/default and it seems like it may also have the same issue but wanted to confirm first.

@langermank
Copy link
Contributor

@joshblack yeah, this is a system-wide update. I'm happy to make the change in PVC if you wanna take the React side 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants