Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavList.Item active state should show up as bold, but doesn't. #4367

Closed
six7 opened this issue Mar 7, 2024 · 2 comments · Fixed by #4392
Closed

NavList.Item active state should show up as bold, but doesn't. #4367

six7 opened this issue Mar 7, 2024 · 2 comments · Fixed by #4392

Comments

@six7
Copy link
Contributor

six7 commented Mar 7, 2024

I noticed that our NavList in React doesnt show the active item with a bold font weight, whereas the Rails example and all the doc images show it as bold.

I'd say we should treat this the same across all implementations.

Image

Image

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Uh oh! @six7, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@joshblack
Copy link
Member

Thanks @langermank for tackling this in UI mob pair! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants