Setting required to input element within TextInput

[fcollonval]

When setting required to TextInput it is not set to the input element - only on the aria attribute:

react/packages/react/src/TextInput/TextInput.tsx

Line 149 in 254e289

aria-required={required}

Could you set it so that built-in form validation can be used fully? For now it is awkward to be able to set a pattern or other constrains but that the component built-in validity is always true if no value is set.

[fcollonval]

The same issue applies to the Textarea component too:

react/packages/react/src/Textarea/Textarea.tsx

Line 97 in 254e289

aria-required={required}

[siddharthkp]

Hi!

This is intentional change. (#4023)

aria-required communicates the same message to screen readers as required, but avoids browser's default validation messages. (which we'd like to do in favor of validation messages from Primer)

Example of default browser validation message and Primer's validation message:

If you'd like to use validation messages that match Primer's design, please use <FormControl.Validation>.
Example in storybook ↗ | Source code for example ↗ | Primer docs ↗

Hope that answers your question. If not, feel free to comment on this issue and I'll open it again!