Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend a component #4

Closed
broccolini opened this issue Feb 20, 2018 · 0 comments
Closed

Extend a component #4

broccolini opened this issue Feb 20, 2018 · 0 comments
Assignees
@broccolini
Projects
Primer Components release tracking 📋

Comments

@broccolini
Copy link
Member

Extend a component (such as buttons) to provide an example of how we'll approach this with any component, such as when do you extend vs add props.
@broccolini broccolini self-assigned this Feb 20, 2018
@broccolini broccolini added this to To do in Primer Components release tracking 📋 via automation Feb 20, 2018
@broccolini broccolini moved this from To do to 🚢Done in Primer Components release tracking 📋 May 21, 2018
siddharthkp added a commit that referenced this issue Apr 10, 2024
@siddharthkp
Revert "Revert "Add loading prop for Button and IconButton (#3582…
60b3253 
…)" (#4…"

This reverts commit c01901f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@broccolini broccolini

Labels
None yet
Projects
No open projects
Primer Components release tracking 📋
  
🚢Published
Milestone
No milestone
Development

No branches or pull requests
1 participant
@broccolini