You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Caret component introduced in #58 has some issues that I'd like to address:
The combination of edge and align props is kind of confusing, and the align prop is currently ignored. I think that a location prop with values like top, top-left, etc. will be more intuitive, and matches the Popover position naming conventions.
As discussed with @jonrohan, it's probably safe to kill off the hacky CSS implementation and just use SVG.
It's currently a pain to coordinate the border and background colors between a Box and Caret, so I'd like to introduce a component that combines them. Possible names include: BoxWithCaret, PointyBox, CaretBox, and CarrotBox...
We should take this opportunity to address the positioning inconsistencies with Popover, and possibly even re-implement Popover as a Box + Caret!
The text was updated successfully, but these errors were encountered:
The Caret component introduced in #58 has some issues that I'd like to address:
edge
andalign
props is kind of confusing, and thealign
prop is currently ignored. I think that alocation
prop with values liketop
,top-left
, etc. will be more intuitive, and matches the Popover position naming conventions.We should take this opportunity to address the positioning inconsistencies with Popover, and possibly even re-implement Popover as a Box + Caret!
The text was updated successfully, but these errors were encountered: