Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caret API improvements #63

Closed
3 tasks done
shawnbot opened this issue Jun 8, 2018 · 1 comment
Closed
3 tasks done

Caret API improvements #63

shawnbot opened this issue Jun 8, 2018 · 1 comment
Labels
💓collab a vibrant hub of collaboration enhancement New feature or request

Comments

@shawnbot
Copy link
Contributor

shawnbot commented Jun 8, 2018 •
edited

The Caret component introduced in #58 has some issues that I'd like to address:

  • The combination of edge and align props is kind of confusing, and the align prop is currently ignored. I think that a location prop with values like top, top-left, etc. will be more intuitive, and matches the Popover position naming conventions.
  • As discussed with @jonrohan, it's probably safe to kill off the hacky CSS implementation and just use SVG.
  • It's currently a pain to coordinate the border and background colors between a Box and Caret, so I'd like to introduce a component that combines them. Possible names include: BoxWithCaret, PointyBox, CaretBox, and CarrotBox... :trollface:

We should take this opportunity to address the positioning inconsistencies with Popover, and possibly even re-implement Popover as a Box + Caret!
@shawnbot shawnbot added enhancement New feature or request 💓collab a vibrant hub of collaboration labels Jun 8, 2018
@shawnbot shawnbot mentioned this issue Jun 14, 2018
Merged
@emplums emplums added this to Backlog in Primer Components release tracking 📋 via automation Jun 21, 2018
@shawnbot shawnbot moved this from Backlog to v0.0.12-beta To Do in Primer Components release tracking 📋 Jul 20, 2018
@shawnbot shawnbot mentioned this issue Jul 20, 2018
Merged
7 tasks
@shawnbot
Copy link
Contributor Author

These are all finished, and have been for some time. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💓collab a vibrant hub of collaboration enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawnbot