Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsx-a11y/recommended eslint config #88

Closed
shawnbot opened this issue Jun 26, 2018 · 1 comment
Closed

Use jsx-a11y/recommended eslint config #88

shawnbot opened this issue Jun 26, 2018 · 1 comment

Comments

@shawnbot
Copy link
Contributor

@emplums inquired in #28 (comment) which jsx-a11y rules eslint-plugin-github uses, which led me to this massive hunk. Emily suggested that we adopt the jsx-a11y/recommended settings instead, which prompted the question:

Why aren't we using the recommended rules in eslint-plugin-github?

Maybe @josh can fill us in. :)

@shawnbot shawnbot added the a11y label Jun 26, 2018
@emplums emplums added a11y and removed 🙈 a11y labels Jul 16, 2018
@emplums emplums moved this from Backlog to Sprint [10/5] To Do in Primer Components release tracking 📋 Oct 10, 2018
@emplums emplums moved this from Sprint [10/5] To Do to 🚢Published in Primer Components release tracking 📋 Oct 10, 2018
@emplums
Copy link

emplums commented Oct 23, 2018

This happened at some point!

@emplums emplums closed this as completed Oct 23, 2018
Primer Components release tracking 📋 automation moved this from 🚢Published to Sprint [10/26] Completed Oct 23, 2018
@emplums emplums moved this from Sprint [10/26] Completed to 🚢Published in Primer Components release tracking 📋 Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants