Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve style arguments docs #120

Closed
joelhawksley opened this issue Oct 22, 2020 · 3 comments
Closed

Improve style arguments docs #120

joelhawksley opened this issue Oct 22, 2020 · 3 comments

Comments

@joelhawksley
Copy link
Contributor

Currently, the style arguments documentation is written from the perspective of migrating from Primer CSS.

While this is helpful for some users of the library, we aren't providing guidance for using style arguments from scratch. I think we should rewrite this documentation to better serve folks using the library for the first time.
@joelhawksley
Copy link
Contributor Author

Note: These docs should include section on passing in a classes argument.

@joelhawksley
Copy link
Contributor Author

Note: We should add a section on data attributes: https://github.slack.com/archives/C0ZCGGGJ2/p1603810527286100

@joelhawksley joelhawksley mentioned this issue Nov 5, 2020
Merged
@joelhawksley joelhawksley mentioned this issue Nov 19, 2020
Merged
@joelhawksley
Copy link
Contributor Author

Closing as https://primer.style/view-components/system-arguments is meaningfully complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joelhawksley