Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure and reduce the number of allocations made by Primer::Classify #155

Closed
BlakeWilliams opened this issue Jan 11, 2021 · 2 comments
Closed

Comments

@BlakeWilliams
Copy link
Contributor

When investigating a page's performance related to allocations, I found that Primer::Classify was performing a significant number of allocations.

The places making the most allocations were:

We should try to measure, then reduce the number of allocations made in that class since it can be a hot path for primer components.

@manuelpuyol
Copy link
Contributor

@BlakeWilliams with #197 and #166

should we close this issue?

@BlakeWilliams
Copy link
Contributor Author

I think we're probably good to close this for now, but can probably write some follow-up issues to prevent regressions, catch new keys, refactor, etc.

Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants