Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to document SlotV2 arguments #188

Closed
manuelpuyol opened this issue Feb 3, 2021 · 1 comment · Fixed by #209
Closed

How to document SlotV2 arguments #188

manuelpuyol opened this issue Feb 3, 2021 · 1 comment · Fixed by #209

Comments

@manuelpuyol
Copy link
Contributor

manuelpuyol commented Feb 3, 2021 •
edited by joelhawksley

Related: #185 (comment)

We need to document arguments for our component's slots. Currently we document directly on their Slot class, but with the introduction of SlotV2 the syntax has changed and we need to decide how to document them.
@joelhawksley
Copy link
Contributor

@manuelpuyol thanks for raising this issue.

My main desires for this change is that the documentation for slots is presented consistently regardless of whether they are declared as classes or lambdas.

Do you have any ideas in mind?

@manuelpuyol manuelpuyol mentioned this issue Feb 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

YARD extension for slots primer/view_components
2 participants
@joelhawksley @manuelpuyol