Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote StateComponent to beta #232

Closed
srt32 opened this issue Feb 16, 2021 · 0 comments · Fixed by #285
Closed

Promote StateComponent to beta #232

srt32 opened this issue Feb 16, 2021 · 0 comments · Fixed by #285
Assignees

Comments

@srt32
Copy link
Contributor

srt32 commented Feb 16, 2021

TODO:

We need to apply functional color changes before promoting.

We want to go from

     COLOR_DEFAULT => "",
      :green => "State--green",
      :red => "State--red",
      :purple => "State--purple"
    }.freeze

to

     COLOR_DEFAULT => "",
      :open  => "State--open",
      :closed => "State--closed",
      :merged => "State--merged"
    }.freeze

We should be able to use #135 as inspiration, which will allow for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant