Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primer::Beta::Flash dismissable action is inactive #2394

Closed
akabiru opened this issue Nov 23, 2023 · 1 comment
Closed

Primer::Beta::Flash dismissable action is inactive #2394

akabiru opened this issue Nov 23, 2023 · 1 comment
Labels
rails

Comments

@akabiru
Copy link

akabiru commented Nov 23, 2023

Hi there 👋🏾 , thanks for the great work on this.

🐛 Primer::Beta::Flash dismissable action is inactive

Seems we need a catalyst action similar to the banner component

flash-dismiss
@akabiru akabiru mentioned this issue Nov 23, 2023
Merged
1 task
@camertron
Copy link
Contributor

camertron commented Nov 27, 2023 •
edited
Loading

Hey @akabiru, thanks for asking about this 😄 To my knowledge, the Flash component has never supported dismissal via the "x" button. It was created before we started attaching behavior with web components. You'll have to do one of the following:

  1. Attach dismiss behavior yourself in javascript.
  2. Use the Banner component instead, which is eventually going to replace Flash.

@khiga8 khiga8 mentioned this issue Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rails
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@camertron @akabiru