Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does this module depend on node >= 6.5? #4

Closed
kumarharsh opened this issue Dec 7, 2016 · 2 comments
Closed

Why does this module depend on node >= 6.5? #4

kumarharsh opened this issue Dec 7, 2016 · 2 comments

Comments

@kumarharsh
Copy link
Contributor

As far as I can see, the postcss-modules-values doesn't need any node engine version. Is there a reason why node version is required for this plugin? I'm using this with nodejs 5.12.0, and it compiles just fine. Can this engine dependency be removed?
@princed princed closed this as completed in 92f3373 Dec 7, 2016
@princed
Copy link
Owner

princed commented Dec 7, 2016

Yep, you're quite right. Published as 1.1.1

@rschamp
Copy link

rschamp commented Feb 21, 2017

This module does not work with Node 4, so I believe some engine warning is warranted. It would be nice if this would work with Node 4+ though, since it is still in LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kumarharsh @princed @rschamp