Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

num_k parameter is not used #40

Closed
dyukha opened this issue Jul 23, 2022 · 4 comments
Closed

num_k parameter is not used #40

dyukha opened this issue Jul 23, 2022 · 4 comments

Comments

@dyukha
Copy link

dyukha commented Jul 23, 2022

run.py accepts parameter num_k, which should control how many training examples per class we have. However, it's not used anywhere in the code. It seems that num_sample is used instead.

@hujian233
Copy link

hujian233 commented Jul 23, 2022 via email

@gaotianyu1350
Copy link
Member

Hi,

You are right that num_k here is a dummy arg. The number of examples is controlled by the dataset you use (for example, our provided preprocessing examples process all the datasets as k=16). Num_sample has a different meaning---it designates how many times of sampling we do for averaging in-context examples for inference.

@dyukha
Copy link
Author

dyukha commented Jul 25, 2022

@gaotianyu1350 , thanks for the reply! Maybe it makes sense to remove num_k? It's also used in examples, which makes it look that the argument actually matters, which can lead to some undesired consequences for a user.

@gaotianyu1350
Copy link
Member

Hi we decide to keep num_k because it is used in logging and searching for a specific run (see our explanation in README about num_k. But thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants