Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify 'run_glue.py' to train model from scratch and eval + danqi mv setup #1

Closed
wants to merge 4 commits into from

Conversation

Danqi7
Copy link

@Danqi7 Danqi7 commented Mar 15, 2021

  1. Modified 'text-classification/run_glue.py' to take in argument '--from_scratch' to enable train random model from scratch and evaluate on selected task
  2. Danqi MV setup script
  3. script to train random models from scratch and eval on selected GLUE task

HF/examples/text-classification/run_glue.py to be able to train/eval on
glue using random models (do not load pre-trained weights)
@Danqi7 Danqi7 requested a review from ameet-1997 March 15, 2021 01:01
export RUN_NO=_random
export OUTPUT_DIR=../../../bucket/model_outputs/glue/$TASK_NAME$RUN_NO/

# Random: --from_scratch + --config_name + --tokenizer_name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a new file for scripts which are different from before? This way we can just keep adding scripts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "eval_random_glue.sh" is a new added script/file?

@@ -114,7 +114,12 @@ class ModelArguments:
Arguments pertaining to which model/config/tokenizer we are going to fine-tune from.
"""

from_scratch: bool = field(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change is small I think it can stay in run_glue.py. But in the future I think we can just make a new copy of run_glue.py and run_mlm.py so that we don't touch the original files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good suggestion! I will make a new copy so we don't ever touch the original files.

@ameet-1997
Copy link
Collaborator

Reminder to add changes to CHANGELOG.md file, ideally with filenames and scripts that you have added/modified.

@Danqi7
Copy link
Author

Danqi7 commented Mar 24, 2021

@ameet-1997 Updated "CHANGELOG.md" and made a copy of the "run_glue.py" to avoid changing the original script.

@ameet-1997 ameet-1997 closed this Oct 27, 2021
@ameet-1997 ameet-1997 deleted the danqi_random branch October 27, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants