Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black format codebase #195

Closed
klieret opened this issue Apr 11, 2024 · 5 comments · Fixed by #433
Closed

Black format codebase #195

klieret opened this issue Apr 11, 2024 · 5 comments · Fixed by #433
Assignees
@klieret
Labels
⭐ code quality
Milestone
0.5.0

Comments

@klieret
Copy link
Member

klieret commented Apr 11, 2024 •
edited

Warning

This is still under discussion, please don't open a PR
@klieret klieret added this to the 0.1.4: Python API & packaging milestone Apr 11, 2024
@klieret klieret self-assigned this Apr 11, 2024
@sakshamcodes01
Copy link

can you elaborate more no this issue?
Are you referring to adding black formatter as the default formatter using the Python packaging?

hminsky2002 added a commit to hminsky2002/SWE-agent that referenced this issue Apr 17, 2024
@hminsky2002
Format codebase
a906e25 
This commit formats all .py files in the codebase
with the black formatter python package, as well as
adds the black package to the environment.yml file.

Issue princeton-nlp#195 Black Format Codebase
hminsky2002 added a commit to hminsky2002/SWE-agent that referenced this issue Apr 17, 2024
@hminsky2002
Add file to ignore initial black commit
be2c4c2 
This commit adds a file to ignore the initial black
formatting of the entire codebase via gitblame. Since it
was an extremely large commit, it could clutter the working
tree/blamelog, so this supplies the option and instructions
to ignore the specific commit when developing

Issue princeton-nlp#195 Black Format Codebase
hminsky2002 added a commit to hminsky2002/SWE-agent that referenced this issue Apr 17, 2024
@hminsky2002
Add black pre-commit hook
1bec962 
This commit adds the black formatter as a pre-commit hook to the
repository

Issue princeton-nlp#195 Black Format Codebase
@hminsky2002 hminsky2002 mentioned this issue Apr 17, 2024
Closed
hminsky2002 added a commit to hminsky2002/SWE-agent that referenced this issue Apr 17, 2024
@hminsky2002
Add black pre-commit hook
bc275d3 
This commit adds the black formatter as a pre-commit hook to the
repository

Issue princeton-nlp#195 Black Format Codebase
hminsky2002 added a commit to hminsky2002/SWE-agent that referenced this issue Apr 17, 2024
@hminsky2002
Add black pre-commit hook
bc53810 
This commit adds the black formatter as a pre-commit hook to the
repository

Issue princeton-nlp#195 Black Format Codebase
@hminsky2002
Copy link

hminsky2002 commented Apr 17, 2024 •
edited

@klieret Made a pr to try and address this issue as well!
PR #251

@Borda
Copy link
Contributor

Borda commented Apr 18, 2024

I see that Ruff has set line length 88 but the length is never checked...

@klieret
Copy link
Member Author

klieret commented Apr 18, 2024 •
edited

ruff formatting is currently not active in pre-commit

@Borda
Copy link
Contributor

Borda commented Apr 18, 2024

ruff formatting is currently not active in pre-commit

Yes, I know, I enabled it locally to see what it will change...
just saying that this line has no effect as the particular rule is also not listed for long lines

SWE-agent/pyproject.toml

Line 117 in 58c5717

line-length = 88

@klieret klieret modified the milestones: 0.3.0, 0.4.0 May 2, 2024
This was referenced May 25, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klieret klieret

Labels
⭐ code quality
Projects
None yet
Milestone
0.5.0
4 participants
@Borda @klieret @hminsky2002 @sakshamcodes01