Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToMatrix() does not have backward operation implemented #1

Closed
lixiny opened this issue Apr 9, 2021 · 2 comments
Closed

ToMatrix() does not have backward operation implemented #1

lixiny opened this issue Apr 9, 2021 · 2 comments

Comments

@lixiny
Copy link

lixiny commented Apr 9, 2021

Hi,

I just read through your paper and code and really adore this project on lie group in tangent space.

I hope that the ToMatrix() operation could be fully differentiable for researchers to use.
Do you have a plan to implement the ToMatrix(), or may be FromMatrix() in the future? and a planned date in mind?

Cheers

Lixin

@zachteed
Copy link
Collaborator

Hi Lixin, I agree this would be good to have. I do have equations for the gradients of ToMatrix so I can add this in the next few days. I will need to think about FromMatrix.

In the future, I am working on trying to make conversions from all different representations differentiable (e.g quaternions, matricies, ect).

Best,
Zach

@lixiny
Copy link
Author

lixiny commented Apr 10, 2021

Best, Zach.
Thanks again for the great contribution you have made.

Lixin

@lixiny lixiny closed this as completed Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants