Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylindrical coord: Geometric source term not implemented on energy equation #3

Closed
wenhuaju opened this issue Oct 21, 2014 · 1 comment
Closed

Cylindrical coord: Geometric source term not implemented on energy equation #3

wenhuaju opened this issue Oct 21, 2014 · 1 comment
Assignees
@jmstone
Labels
invalid Out of the current scope of Athena++

Comments

@wenhuaju
Copy link

In cylindrical.cpp, geometric source terms are only implemented on IM1 and IM2, but haven't been implemented on IEN yet (Velocity dot Force).
@wenhuaju wenhuaju added the bug Broken functionality or unexpected result label Oct 21, 2014
@wenhuaju
Copy link
Author

Kengo just talked to me and pointed out that there shouldn't be geometric src term on IEN, because ther energy flux is a vector, not a tensor. The energy equation is already in conservative form. Therefore, there should not be an geometric src term on IEN, and the current version is correct.

@tomidakn tomidakn closed this as completed Dec 7, 2014
@felker felker added invalid Out of the current scope of Athena++ and removed bug Broken functionality or unexpected result labels May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmstone jmstone

Labels
invalid Out of the current scope of Athena++
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@felker @jmstone @tomidakn @wenhuaju