Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better default behavior when setting start_time #36

Closed
c-white opened this issue Oct 4, 2017 · 2 comments
Closed

Need better default behavior when setting start_time #36

c-white opened this issue Oct 4, 2017 · 2 comments
Assignees
Labels
bug Broken functionality or unexpected result file IO Relating to writing/reading of .tab, .hdf5, .vtk, etc

Comments

@c-white
Copy link
Contributor

c-white commented Oct 4, 2017

If a user specifies the time/start_time input parameter, then the the initial output*/next_time parameters still default to 0 if omitted. Because these are only incremented by dt, next_time will always be start_time less than the current time, so output will be written every timestep.

Now a user can always set all the next_time parameters manually, but I can't imaging ever wanting the default to be 0 when start_time is not 0. I think changing the linked line will fix this, but I wanted to double check.

@c-white c-white added the bug Broken functionality or unexpected result label Oct 4, 2017
@jmstone
Copy link
Contributor

jmstone commented Oct 4, 2017

This behavior was a problem in Athena4.2. I think the fix used there is that restarts save the output*/next_time data, so when you restart you don't get an output every time step (check Athena4.2 to be sure). Certainly something like this should be implemented in Athena++.

@msbc
Copy link
Contributor

msbc commented Feb 2, 2018

I've added a "restart_tweak" branch to try fixing this issue along with #62. I think (needs testing) I fixed #36 with this line in the outputs constructor, making next_time default to the mesh time if unset.

@felker felker self-assigned this Apr 17, 2018
@felker felker changed the title Better default behavior when setting start_time Need better default behavior when setting start_time May 25, 2018
@felker felker added the file IO Relating to writing/reading of .tab, .hdf5, .vtk, etc label May 25, 2018
@felker felker removed their assignment May 31, 2018
@felker felker self-assigned this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken functionality or unexpected result file IO Relating to writing/reading of .tab, .hdf5, .vtk, etc
Projects
None yet
Development

No branches or pull requests

4 participants