Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting NGHOST at runtime #53

Closed
tomidakn opened this issue Jan 7, 2018 · 0 comments
Closed

Setting NGHOST at runtime #53

tomidakn opened this issue Jan 7, 2018 · 0 comments
Labels
enhancement Improve an existing Athena++ component wontfix No action planned

Comments

@tomidakn
Copy link
Contributor

tomidakn commented Jan 7, 2018

Currently NGHOST is hard coded in defs.hpp.in as a constant fixed at cofiguration, but for higher order reconstruction this must be flexible. As the reconstruction order can be set at runtime, I think it is better to make NGHOST a normal variable initialized at the beginning of a simulation according to the reconstruction order and use of SMR/AMR.

Note that for SMR/AMR NGHOST must be even. For the third order reconstruction, it is OK to use NGHOST=3 on a uniform grid but it must be 4 with SMR/AMR because of the prolongation algorithm.

@tomidakn tomidakn added enhancement Improve an existing Athena++ component feature request Add brand new functionality to Athena++ labels Jan 7, 2018
@felker felker added wontfix No action planned and removed feature request Add brand new functionality to Athena++ labels Apr 12, 2018
@felker felker closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing Athena++ component wontfix No action planned
Projects
None yet
Development

No branches or pull requests

2 participants