Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concern: remove_zeros in pseudo_poly #28

Closed
jakevdp opened this issue Mar 30, 2017 · 1 comment
Closed

Concern: remove_zeros in pseudo_poly #28

jakevdp opened this issue Mar 30, 2017 · 1 comment

Comments

@jakevdp
Copy link
Collaborator

jakevdp commented Mar 30, 2017

This seems like a bit of a hack to me, and I'm worried about its implications. It would be useful to have this tunable at the highest level, so we can make sure it's not impacting results negatively.

@johnh2o2
Copy link
Collaborator

Hi Jake,

I agree with you here -- it's leftover from when I was trying to figure out the source of failures when recovering closely-spaced roots in the pseudo polynomial module. That's all been fixed now, and I've replaced the arrays of coefficients Polynomial instances to make things easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants