Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Make helper functions of format/base.go public to be able to easily extend format.Format #38

Closed
bastantoine opened this issue May 27, 2021 · 3 comments · Fixed by #43

Comments

@bastantoine
Copy link
Contributor

Hello!

I've just discovered your tool, it's awesome and really useful!

I'm using your tool for a work project, but I need to tweak a bit the rendered markdown files. I saw that there are bunch of markdown helpers (bold, header, link...) in format/base.go that you use in all the implementation of format.Format (PlainMarkdown, GitHubFlavoredMarkdown and AzureDevOpsMarkdown).

I was wondering if it would be possible to export those helpers so that its easy to create a custom implementation of format.Format, without having to rewrite those helpers?

I'd be happy to send a PR if that's okay with you!

@bastantoine
Copy link
Contributor Author

Hello @princjef ! Any news on this?

@princjef
Copy link
Owner

princjef commented Jun 5, 2021

Hey @bastantoine, that sounds like a great idea! If you want to put together a PR with the changes I'll take a look and we can get it merged

@bastantoine
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants