Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility functions in a template - Please vote #134

Closed
4 tasks
iamclaytonray opened this issue Nov 23, 2017 · 3 comments
Closed
4 tasks

Utility functions in a template - Please vote #134

iamclaytonray opened this issue Nov 23, 2017 · 3 comments

Comments

@iamclaytonray
Copy link
Contributor

Currently, utility functions are not supported very well in the current templates. I'm proposing (and will implement in a PR if I receive enough upvotes), a bunch of functions for common tasks.

  • Password hashing/salting/encryption
  • Email verification (checks to see if the email is valid; if not, reformats the email)
  • Slug verification (similar as above)
  • Phone number verification (similar as above)

That's enough to get started with, for now. I'd love to hear other general utility functions that you see a use-case for.

Please only vote on this issue. Do not spam with a million comments. To make it easier, I have voted with a thumbs up and a thumbs down. Please keep comments to other features and questions so that we can be more productive.

Also, happy Thanksgiving everyone!

@kbrandwijk
Copy link
Contributor

Somewhat related: https://github.com/graphcool/framework/issues/736. These functions could live in a separate package for easy re-use.

@iamclaytonray
Copy link
Contributor Author

I think the benefit in throwing them into a template would be to add hooks into functions that are controlled. What are your thoughts? My initial thoughts on throwing them onto NPM would be lack of control and less extension for individual functions.

@iamclaytonray
Copy link
Contributor Author

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants