Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build command mvp #3

Closed
jasonkuhrt opened this issue Oct 29, 2019 · 0 comments
Closed

build command mvp #3

jasonkuhrt opened this issue Oct 29, 2019 · 0 comments
Labels
effort/modest scope/builder type/feat Add a new capability or enhance an existing one

Comments

@jasonkuhrt
Copy link
Member

jasonkuhrt commented Oct 29, 2019

Needs #10

Problem

Users must apply a specific combination of tools and configurations thereof to successfully build their app "the nexus way".

For example:

Spec

At a high level:

  • Run Nexus typegen
  • Then run a real TS build

In Detail

  • Assume that entrypoint is src/server.ts

  • Set environment variable PUMPKINS_TYPEGEN='true'

  • there should be an entrypoint flag for running typegen

  • if user provides nexus entrypoint config in package json and user does not pass entrypoint cli flag then use the package json variant

  • Use the Compiler API to find the user's tsconfig.json and honour it

  • peer dep on typescript, using a range as wide as possible

We may want to use https://github.com/davidtheclark/cosmiconfig

  • if no json config is found and no cli flag is passed then fallback to the following lookups:
src/schema/index.ts
src/schema.ts
src/server.ts
src/main.ts
src/index.ts
schema/index.ts
schema.ts
server.ts
main.ts
index.ts
ERROR (please pass entrypoint)

Some original build design started in #272 (comment) and original cli work began in #275.

@jasonkuhrt jasonkuhrt added type/feat Add a new capability or enhance an existing one scope/builder labels Oct 29, 2019
@jasonkuhrt jasonkuhrt added this to Sprint in Labs Team Oct 30, 2019
@jasonkuhrt jasonkuhrt changed the title build command build command mvp Nov 6, 2019
@jasonkuhrt jasonkuhrt moved this from Current Sprint to In Progress in Labs Team Nov 6, 2019
Labs Team automation moved this from In Progress to Shipped Nov 6, 2019
@schickling schickling removed this from Shipped in Labs Team Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/modest scope/builder type/feat Add a new capability or enhance an existing one
Projects
None yet
Development

No branches or pull requests

1 participant