IDFilter input type for consistency

[jasonkuhrt]

Instead of:

type A {
  id: ID
  s:  String
}

input AWhereInput {
  id: StringFilter
  s:  StringFilter
}

We should have:

type A {
  id: ID
  s:  String
}

input AWhereInput {
  id: IDFilter
  s:  StringFilter
}

There is already precedent for filters that have the same structure: IntFilter / FloatFilter.

[dbtek]

Apparently I reported this on wrong repository. Closing it on prisma2.

[jasonkuhrt]

Reviewing my opening comment, think I made a mistake?

This:

input AWhereInput {
  id: StringFilter
  s:  IDFilter
}

should be:

input AWhereInput {
  id: IDFilter
  s:  StringFilter
}

🤔haha why did I do that before...

@dbtek does that line up with your expectation?

[dbtek]

I noticed @jasonkuhrt. If I'm correct, there is no type as IDFilter, ID is used instead.

[jasonkuhrt]

@dbtek that part is intentional. Its a notation used by nexus-prisma docs to communicate GraphQL Schema contributions. More here: https://github.com/prisma-labs/nexus-prisma#how-to-read

[dbtek]

Oh I see. Sorry for being such a noob.

[jasonkuhrt]

All ears if you have ideas on how to make that part more accessible! Maybe we should front load that “legend” so if you’re just scrolling down it’ll be more visible...

_{Sent with GitHawk}