Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better information for invalid queries #16

Closed
marktani opened this issue Dec 19, 2017 · 6 comments
Closed

Better information for invalid queries #16

marktani opened this issue Dec 19, 2017 · 6 comments

Comments

@marktani
Copy link
Contributor

bildschirmfoto 2017-12-19 um 20 07 08

this currently returns null, instead of a helpful error message.

The error is that the code should say id: userId instead of id: { userId }.

@schickling
Copy link
Contributor

Pending: ardatan/graphql-tools#550

@kbrandwijk
Copy link
Contributor

kbrandwijk commented Jan 5, 2018

@marktani Also, would it help you that the static bindings pick this up at design-time, and you will get a type error?

@marktani
Copy link
Contributor Author

marktani commented Jan 5, 2018

Yes, that is ~~~/would be~~~ tremendously helpful!

@kbrandwijk
Copy link
Contributor

image

@schickling
Copy link
Contributor

We should still try to find a way to provide better run-time validation for dynamic bindings.

@maticzav
Copy link
Collaborator

Hey 👋, I believe this issue is no longer in sync with the current prisma-binding. The new graphql-binding code generator also features a very robust interface system which probably fixes the problem described here.

Feel free to reopen the issue if you believe we should further discuss it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants