New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clearer that soft delete middleware is just a proof of concept, not our soft delete solution #2508
Comments
Options (possible some combo):
Perhaps we start with option number 1, and then do option number 3 now, then work with Devs to align on option number 4. Let's ask @andrewicarlson if he has data on how many people use this, and in what scenarios. There are no Docs PRs on this. |
Tana and I have agreed to do 1 and 3 immediately, so the doc isn't misleading, and then research 4. |
I'm going to create a separate docs issue for 1 and 3, so that we can progress that work as a discrete unit. Edit: here it is: #3727 |
We have the following list of possible exceptions with the soft delete middleware. However, we need to confirm these before we add them to the docs. In addition, we have an open engineering ticket that aims to fix some of this, which I'm monitoring. LimitationsThe soft delete sample on this page is not a full implementation. In the options above, we explain some of the limitations. Other limitations include the following:
|
Update: 5-Sep-2022, Andrew W
I'm investigating, but my first instinct is that we should signpost this in the page title - something like "Middleware example: soft delete" and then put an admonition saying something like "This is an example of what you can do with middleware - it is not the official soft delete in Prisma". If we do that, we'll also need to make equivalent changes to the other middleware examples pages, for uniformity's sake.
https://www.prisma.io/docs/concepts/components/prisma-client/middleware/soft-delete-middleware
Our users regularly misunderstand that this is just a proof of concept of something you can do with a middleware, not the ultimate solution to implement soft deletes in Prisma: prisma/prisma#3398 (comment) (and many more messages in that thread before)
We should fix that somehow.
The text was updated successfully, but these errors were encountered: