Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify-github: Not actually testing current deploy, but last deploy, and is fine if that is of same version #1614

Open
janpio opened this issue Apr 10, 2021 · 2 comments

Comments

@janpio
Copy link
Member

janpio commented Apr 10, 2021

The logic in https://github.com/prisma/e2e-tests/tree/dev/platforms/netlify-ci effectively only works, if we deploy a new version. If we redeploy the same version, the logic is perfectly fine with a previous deployment of the same Prisma version (as a version comparison is the only thing used to confirm the deployment).

Solutions:

  • Check actual deployment, not the main URL for when the deployment is put into "production"
  • Add something unique to the deployment that is being checked for
@janpio janpio added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. labels Apr 10, 2021
@janpio
Copy link
Member Author

janpio commented Apr 10, 2021

Might also apply to other tests that deploy to an environment that could have earlier, working deployments.

@janpio
Copy link
Member Author

janpio commented Apr 10, 2021

Specialized solution for Netlify would be to use https://docs.netlify.com/configure-builds/environment-variables/#git-metadata - that is known to the script pushing to the Github repo. But a bit complicated, as those are not available in Functions env by default but would have to be injected into the function code on build time.

Of course only works for netlify-ci specifically. More generalized solution might be better.

@janpio janpio changed the title netlify-ci: Not actually testing current deploy, but last deploy, and is fine if that is of same version netlify-github: Not actually testing current deploy, but last deploy, and is fine if that is of same version Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. topic: netlify topic: serverless
Development

No branches or pull requests

1 participant